[PATCH] D27114: Preserve nonnull metadata on Loads through SROA & mem2reg.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 17 16:21:25 PDT 2017


efriedma added a comment.

I was hoping Chandler would continue to review, but I guess I can do it.

The test here is really bare-bones; it doesn't really cover all the relevant codepaths.  It doesn't check the effect of the isKnownNonNullAt, and it doesn't cover one of the codepaths in PromoteMemoryToRegister.cpp at all.

Otherwise looks fine per earlier discussion.


https://reviews.llvm.org/D27114





More information about the llvm-commits mailing list