[PATCH] D30958: [CMake] Support building Fuchsia toolchain on Darwin

[Petr Hosek via Phabricator via llvm-commits]

phosek marked 2 inline comments as done.
phosek added inline comments.


================
Comment at: cmake/caches/Fuchsia.cmake:3
 
-set(LLVM_TARGETS_TO_BUILD Native CACHE STRING "")
+if(NOT APPLE)
+  set(LLVM_TARGETS_TO_BUILD Native CACHE STRING "")
----------------
phosek wrote:
> phosek wrote:
> > This is only needed because the first stage compiler is building host builtins which on Darwin require extra architecture support. I don't know if there is a way to disable this behavior? One option I can think of would be to set `LLVM_BUILTIN_TARGETS` to `""`. Alternative would be to add a new CMake option, e.g. `LLVM_INCLUDE_RUNTIMES`.
> I've implemented that option in D31060.
Turned out this is not going to work since the runtimes build is apparently needed by the second stage compiler.


Repository:
  rL LLVM

https://reviews.llvm.org/D30958