[PATCH] D30846: AMDGPU: Unify divergent function exits.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 17 14:38:03 PDT 2017


arsenm added a comment.

In https://reviews.llvm.org/D30846#704342, @jlebar wrote:

> Something in particular you'd like me to review here?  I'm probably not the best person to review inside AMDGPU/.


You were looking at some structurizer issues, so this may have been related to some of them. One concern I have is now there's a fragile pass ordering issue. My original attempt was able to add a pass dependency on the generic UnifyFunctionExit pass, so it auto-ensures this invariant when running the structurize pass. However I don't think I can easily add a dependency on the target specific divergence aware version


https://reviews.llvm.org/D30846





More information about the llvm-commits mailing list