[PATCH] D30914: [Outliner] Add outliner for AArch64

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 17 14:18:58 PDT 2017


MatzeB accepted this revision.
MatzeB added a comment.
This revision is now accepted and ready to land.

LGTM, just check that return false branch (see below).

We should also have a test for the behavior on overflowing offset operands. However I see that this is really hard to test with .ll files so go ahead for now but please add a TODO and implement it later when we have fixed .mir parsing to work with passes that create new functions like the outliner.



================
Comment at: lib/Target/AArch64/AArch64InstrInfo.cpp:1691
+  int64_t Dummy1, Dummy2;
+  getMemOpInfo(LdSt.getOpcode(), Scale, Width, Dummy1, Dummy2);
+
----------------
This had
```
 default: return false;
```
before, was this case impossible to hit or do we need `if (!getMemOpInfo()) return false`?


https://reviews.llvm.org/D30914





More information about the llvm-commits mailing list