[PATCH] D31100: [LTO] Allow client to skip code gen

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 17 14:06:35 PDT 2017


mehdi_amini added a comment.

> We noticed that when invoking the thinBackend via clang (for the distributed build case) that flags like -ffunction-sections and -emit-llvm were not having the intended effect. This could have been fixed by setting up the TargetOptions and the CodeGenFileType in the LTO Config, but since clang already has handling for all of this, it is straightforward to just let it do the handling.

Well, I'm not convinced it is the right thing to do. It is the most straightforward thing to do for the distributed case, but it creates a discrepancy with the non-distributed case, and it won't allow to honor -ffunction-sections this way.
I also believe that it won't help to guarantee that wether you're using a distributed build or not you get the same binary.


https://reviews.llvm.org/D31100





More information about the llvm-commits mailing list