[PATCH] D30767: Updates branch_weights annotation for call instructions during inlining.

Z. Zheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 17 10:49:57 PDT 2017


zzheng added a comment.

a couple more nitpicks... please check all use of Optional variables



================
Comment at: lib/Transforms/Utils/InlineFunction.cpp:1466
   Optional<uint64_t> CalleeCount = Callee->getEntryCount();
   if (!CalleeCount)
     return;
----------------
!CalleeCount.hasValue()


================
Comment at: lib/Transforms/Utils/InlineFunction.cpp:1470
+      ProfileSummaryInfo::getProfileCount(CallInst, CallerBFI);
+  if (!CallCount)
     return;
----------------
!CallCount.hasValue()


https://reviews.llvm.org/D30767





More information about the llvm-commits mailing list