[PATCH] D30225: [LIR] re-enable generation of memmove with runtime checks

Krzysztof Parzyszek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 17 08:17:55 PDT 2017


kparzysz added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopIdiomRecognize.cpp:986
+    }
+  }
+
----------------
efriedma wrote:
> This whole worklist thing looks very suspicious; for the purpose of figuring out whether the memmove covers the loop, why do you need to special-case the pointer operand of the load instruction?
Could you explain the "special-casing" comment?  I'm not seeing what you are referring to.


https://reviews.llvm.org/D30225





More information about the llvm-commits mailing list