[PATCH] D31070: Turn some C-style vararg into variadic templates

serge via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 17 04:13:17 PDT 2017


serge-sans-paille created this revision.
Herald added a subscriber: mzolotukhin.

Module::getOrInsertFunction is using C-style vararg instead of variadic templates.

>From a user prospective, it forces the use of an annoying nullptr to mark the end of the vararg, and there's not type checking on the arguments.
The variadic template is an obvious solution to both issues.


Repository:
  rL LLVM

https://reviews.llvm.org/D31070

Files:
  include/llvm/IR/Module.h
  lib/CodeGen/CountingFunctionInserter.cpp
  lib/CodeGen/IntrinsicLowering.cpp
  lib/CodeGen/MachineOutliner.cpp
  lib/CodeGen/SafeStack.cpp
  lib/CodeGen/SjLjEHPrepare.cpp
  lib/CodeGen/StackProtector.cpp
  lib/CodeGen/TargetLoweringBase.cpp
  lib/IR/Instructions.cpp
  lib/IR/Module.cpp
  lib/Target/X86/X86ISelLowering.cpp
  lib/Transforms/IPO/CrossDSOCFI.cpp
  lib/Transforms/IPO/WholeProgramDevirt.cpp
  lib/Transforms/Instrumentation/AddressSanitizer.cpp
  lib/Transforms/Instrumentation/EfficiencySanitizer.cpp
  lib/Transforms/Instrumentation/MemorySanitizer.cpp
  lib/Transforms/Instrumentation/SanitizerCoverage.cpp
  lib/Transforms/Instrumentation/ThreadSanitizer.cpp
  lib/Transforms/Scalar/LoopIdiomRecognize.cpp
  lib/Transforms/Utils/BuildLibCalls.cpp
  lib/Transforms/Utils/SimplifyLibCalls.cpp
  tools/lli/lli.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D31070.92122.patch
Type: text/x-patch
Size: 45542 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170317/5a1a7a27/attachment.bin>


More information about the llvm-commits mailing list