[PATCH] D30121: [asan] Fix dead stripping of globals on Linux.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: lib/Transforms/Instrumentation/AddressSanitizer.cpp:129
+// ASan version script has __asan_* wildcard. Triple underscore prevents
+// exporting of this _local_ symbol.
 static const char *const kAsanGlobalsRegisteredFlagName =
----------------
What happens if you use double underscore? I would have thought that hidden visibility was enough to prevent this symbol from being exported.


================
Comment at: lib/Transforms/Utils/ModuleUtils.cpp:233
+
+std::string llvm::getUniqueModuleId(Module *M) {
+  MD5 Md5;
----------------
Can you change ThinLTOBitcodeWriter to use this function as well?


Repository:
  rL LLVM

https://reviews.llvm.org/D30121