[PATCH] D30962: [GlobalISel] Translate shufflevector

Javed Absar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 16 14:42:28 PDT 2017


javed.absar added a comment.

Thanks Volkan.
Adding a zip to the test above might make the testing stronger, i.e something like shufflevector <8 x i8> %tmp1, <8 x i8> %tmp2, <16 x i32> <i32 0, i32 8, i32 1, i32 9, i32 2, i32 10, i32 3, i32 11, i32 4, i32 12, i32 5, i32 13, i32 6, i32 14, i32 7, i32 15>

Also, would you consider adding a test for arm (32-bit) as well (need not be a big one).
Best Regards.


https://reviews.llvm.org/D30962





More information about the llvm-commits mailing list