[PATCH] D31032: [LoadCombine] Avoid analysing dead basic blocks

Noel Grandin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 16 11:39:39 PDT 2017


grandinj added inline comments.


================
Comment at: lib/Transforms/Scalar/LoadCombine.cpp:233
+bool LoadCombine::runOnBasicBlock(BasicBlock &BB, bool IsAlive) {
+  if (skipBasicBlock(BB) || !IsAlive)
     return false;
----------------
presumably checking IsAlive is cheaper than calling skipBasicBlock, so maybe it should be tested first?


https://reviews.llvm.org/D31032





More information about the llvm-commits mailing list