[llvm] r297823 - Fix malformed XFAIL in previous commit

[Rackover, Zvi via llvm-commits]

The fix was committed and the XFAIL was removed from the test. Sorry about the inconvenience.

From: Zachary Turner [mailto:zturner at google.com]
Sent: Wednesday, March 15, 2017 20:45
To: Rackover, Zvi <zvi.rackover at intel.com>; llvm-commits at lists.llvm.org
Subject: Re: [llvm] r297823 - Fix malformed XFAIL in previous commit

I'm running a debug build, so asserts are in fact enabled.

On Wed, Mar 15, 2017 at 11:18 AM Rackover, Zvi <zvi.rackover at intel.com<mailto:zvi.rackover at intel.com>> wrote:
I counted 95 LIT tests marked as “XFAIL: *”. I agree that keeping a test in such a state for a long time is undesirable.
But I also uploaded a fix candidate, https://reviews.llvm.org/D30978, so if all goes well the test won’t remain an XFAIL for long.

Are you running with a build with assertions disabled? If yes, that may explain why the test passes unexpectedly on your build. I’m not sure what is the policy about Release+NoAssertions builds, but I can remove the test if this the only test that fails in that configuration.

From: Zachary Turner [mailto:zturner at google.com<mailto:zturner at google.com>]
Sent: Wednesday, March 15, 2017 19:59
To: Rackover, Zvi <zvi.rackover at intel.com<mailto:zvi.rackover at intel.com>>; llvm-commits at lists.llvm.org<mailto:llvm-commits at lists.llvm.org>
Subject: Re: [llvm] r297823 - Fix malformed XFAIL in previous commit

Why does this have XFAIL: *?  It's passing on my machine  which is being treated as a failure since it's expected to fail but doesn't.  In any case, what is the point of having a test which is expected to fail everywhere?

On Wed, Mar 15, 2017 at 4:56 AM Zvi Rackover via llvm-commits <llvm-commits at lists.llvm.org<mailto:llvm-commits at lists.llvm.org>> wrote:
Author: zvi
Date: Wed Mar 15 06:44:14 2017
New Revision: 297823

URL: http://llvm.org/viewvc/llvm-project?rev=297823&view=rev
Log:
Fix malformed XFAIL in previous commit

Modified:
    llvm/trunk/test/CodeGen/Generic/pr32278.ll

Modified: llvm/trunk/test/CodeGen/Generic/pr32278.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/Generic/pr32278.ll?rev=297823&r1=297822&r2=297823&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/Generic/pr32278.ll (original)
+++ llvm/trunk/test/CodeGen/Generic/pr32278.ll Wed Mar 15 06:44:14 2017
@@ -1,5 +1,5 @@
 ; PR32278
-; XFAIL:
+; XFAIL: *

 ; RUN: llc < %s



_______________________________________________
llvm-commits mailing list
llvm-commits at lists.llvm.org<mailto:llvm-commits at lists.llvm.org>
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits

---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170316/18fdcefb/attachment.html>