[PATCH] D30747: TargetInstrInfo: Provide default implementation of isTailCall().

[Dean Michael Berris via Phabricator via llvm-commits]

dberris accepted this revision.
dberris added a comment.
This revision is now accepted and ready to land.

LGTM -- I suspect this doesn't break the compiler-rt tests for XRay?



================
Comment at: include/llvm/Target/TargetInstrInfo.h:1499-1501
+  /// Determines whether \p Inst is a tail call instruction. There is no need to
+  /// override this method, unless the target doesn't model the isCall/isReturn
+  /// flags correctly!
----------------
Can we make this comment more direct? Something like:

"Override this method for targets where tail calls are not always both return and call instructions."


Repository:
  rL LLVM

https://reviews.llvm.org/D30747