[PATCH] D31011: recommend using llvm-ar when finding undefined references and empty archives

Bob Haarman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 15 16:19:26 PDT 2017


inglorion added inline comments.


================
Comment at: ELF/Error.cpp:87
   }
+  if (shouldExit) exitLld(1);
+}
----------------
Since we can't lock a mutex we already hold, exitLld must be called without holding the lock on Mu. This makes the structure of the code here quite unfortunate. Is there a more elegant way to get this to work?


https://reviews.llvm.org/D31011





More information about the llvm-commits mailing list