[PATCH] D30939: [ELF] - Split struct In<ELFT> to have templated and non-templated sections areas.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 15 07:51:42 PDT 2017


George Rimar via Phabricator <reviews at reviews.llvm.org> writes:

> grimar added a comment.
>
> In https://reviews.llvm.org/D30939#700740, @ruiu wrote:
>
>> This removes template parameter from only three sections among 27 sections, and now you have to append `X` everywhere. Is this really worth it? I wonder if we should just wait for C++14 template variable.
>
>
> After today there are 13 such sections. The approach of splitting In structure is itself very usefull. I showed that in https://reviews.llvm.org/D30982.
> I applied @evgeny777 suggestion to have base and derived class to reduce amount of changes required.

Can you move back here the change that just splits the struct in 2?

Cheers,
Rafael


More information about the llvm-commits mailing list