[PATCH] D30887: [ScalarEvolution] Predicate implication from operations

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev added a comment.

Hi Sanjoy!

Thank you for review and detailed comment, I will try to address them all soon as I can!

>> Why not:
>>  (A >= 0 && B > X)  ==>  ((A +nsw B) > X?

Good catch!

>> (A > X) && (-B <= X < 0) ===> (A / B > 0), what if X is -10, A is -5 and B is 10? Won't A / B be 0 then?

Thanks for pointing out, actuall the commit message is wrong. It should be "A / B >= 0". Line 8590 checks that RHS should be negative.


https://reviews.llvm.org/D30887