[PATCH] D29948: [AMDGPU] Restructure code object metadata creation

Konstantin Zhuravlyov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 14 17:15:13 PDT 2017


kzhuravl added a comment.

In https://reviews.llvm.org/D29948#693533, @yaxunl wrote:

> Can you add Nikolay as reviewer since changes to the shared header file will affect him. The header file is not solely controlled by compiler.
>
> One way to put things in that header file in llvm name space without changing the header file itself is
>
>   namespace llvm {
>   #include "that_header"
>   }
>
>
> Does that work for you?


As discussed last week, we are not exposing this header, so llvm namespace sounds ok.


https://reviews.llvm.org/D29948





More information about the llvm-commits mailing list