[PATCH] D30562: Add Instruction number to LSR cost model (PR23384) part 3 of 3

Tue Mar 14 15:56:56 PDT 2017

evstupac added a comment.

Hi Quentin,

> I see two different things in that patch:

> 1. X86 cost model change
> 2. GenerateCrossUseICmpZero
> 
> Please make two separate patches.

ok. I thought that since 2. does not make any difference without -lsr-insns-cost it would be fair to commit it with 1.

> For both cases, I expect a thorough benchmarking numbers for Os and https://reviews.llvm.org/owners/package/3/.

2. itself do not make any significant difference. For most benchmarks I've got build same.

For 1. I received only one feedback to llvm-dev:
400.perlbench 1.001288
401.bzip2 0.996352
445.gobmk 0.998473
456.hmmer 1.009015
458.sjeng 1.011942
462.libquantum 1.003234
464.h264ref 0.995798
471.omnetpp 1.004245
473.astar 1.002221
483.xalancbmk 0.993139
403.gcc 1.001213
429.mcf 1.004345
Geomean 1.00176

My own measurements a generally better for x86 (however I ran only -O2 and -Ofast).

Thanks,
Evgeny

Repository:
  rL LLVM

https://reviews.llvm.org/D30562