[PATCH] D30626: MachineScheduler/ScheduleDAG: Add support for GetSubGraph

[Hal Finkel via Phabricator via llvm-commits]

hfinkel accepted this revision.
hfinkel added a comment.

In https://reviews.llvm.org/D30626#700951, @axeldavy wrote:

> Added full context


Small comment about the assert, but otherwise LGTM too.



================
Comment at: lib/CodeGen/ScheduleDAG.cpp:624
+
+  assert(Found);
+  Success = true;
----------------
This assert should have a comment, but instead of tracking Found again, maybe it would be even better to do this:

  assert(VisitedBack.size() == Visited.size() && "Did not collect all subgraph nodes?");
 


Repository:
  rL LLVM

https://reviews.llvm.org/D30626