[PATCH] D30438: SplitKit: Correctly implement partial copies

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 14 14:01:33 PDT 2017


rampitec added inline comments.


================
Comment at: lib/CodeGen/VirtRegMap.cpp:384
+
+  if (MI.isBundledWithPred() && !MI.isBundledWithSucc()) {
+    // Only do this when the complete bundle is made out of COPYs.
----------------
I think it can break something which was bundled not by SplitKit. I wish we could mark these somehow... It will not happen now because we do not use bundles, but potentially a problem. Maybe insert some sort of a marker into the bundle or slot, or create a new MIFlag? Ideally of course it shall not use bundles just to keep LIS correct :(


Repository:
  rL LLVM

https://reviews.llvm.org/D30438





More information about the llvm-commits mailing list