[PATCH] D30785: [DWARF] Versioning for DWARF constants; verify FORMs

[Adrian Prantl via llvm-commits]

> On Mar 13, 2017, at 2:50 PM, Robinson, Paul <paul.robinson at sony.com> wrote:
> 
> We don't use ref_sig8 (or any signatures) for "externally defined" types any more, so what David says sound fine to me.
>  
> -- adrian
>  
> Unfortunately, llvm/test/DebugInfo/X86/externaltyperef.ll disagrees with that statement; DwarfUnit::addDIETypeSignature still has an overload with a 'StringRef Identifier' parameter that emits form ref_sig8, and DwarfUnit::constructTypeDIE still calls that overload for external type refs.  So I'm not sure what you are saying here.
> Has the design evolved but the code hasn't caught up yet? <>
Yes, I should delete that testcase. It was in preparation of a design that never saw the light of the day. We now emit external type references as a forward declaration inside a DW_TAG_module. This way we can look up the type definitions by declcontext in either DWARF of the clang module.

-- adrian

>  <>
> Thanks,
> --paulr

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170313/9441b86e/attachment.html>