[PATCH] D30890: Post-dom fix - connect virtual edges to last reverse-reachable BB

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 13 12:52:19 PDT 2017


efriedma added a comment.

I see a couple problems with this:

1. There isn't any easy way for passes which use PostDominatorTree to walk the CFG including these fake edges.
2. For consistency, we would want other analysis and transform passes (DominatorTree/DominanceFrontier/LoopInfo/etc.) to reason about the CFG using the same fake edges as the PostDominatorTree; otherwise, you can't really rely on the results of the PostDominatorTree analysis.  I'm not exactly sure what the total impact would be, but it seems complicated at first glance.


https://reviews.llvm.org/D30890





More information about the llvm-commits mailing list