[PATCH] D30758: Update clang-cl driver for MSVC 2017

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 13 11:42:27 PDT 2017


zturner added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/MSVCSetupApi.h:3
+// Copyright (C) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT license. See LICENSE.txt in the project root for
+// license information.
----------------
dberlin wrote:
> There is no project root, you should paste the LICENSE.txt into the header directly.
> Also, generally, i would segregate this into a third_party directory, as keeping code like this directly in the rest of the project makes it a lot messier
Is a third_party directory directly in this folder ok, or should it be some kind of top level third_party directory?


https://reviews.llvm.org/D30758





More information about the llvm-commits mailing list