[PATCH] D30670: [Outliner] Add tail call support

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 13 11:24:38 PDT 2017


MatzeB accepted this revision.
MatzeB added a comment.
This revision is now accepted and ready to land.

LGTM with nitpicks addressed.



================
Comment at: test/CodeGen/X86/machine-outliner-tailcalls.ll:9
+; CHECK-NEXT: .cfi_endproc
+  store i32 0, i32* @x, align 4, !tbaa !2
+  %2 = tail call i32 @ext(i32 1) #2
----------------
You can probably remove the `!tbaa` bits


================
Comment at: test/CodeGen/X86/machine-outliner-tailcalls.ll:27-30
+!2 = !{!3, !3, i64 0}
+!3 = !{!"int", !4, i64 0}
+!4 = !{!"omnipotent char", !5, i64 0}
+!5 = !{!"Simple C/C++ TBAA"}
----------------
This can be removed if the `tbaa` bits are gone.


https://reviews.llvm.org/D30670





More information about the llvm-commits mailing list