[PATCH] D30541: [ELF] - Make Bss and BssRelRo sections to be synthetic (#2).

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 13 07:28:44 PDT 2017


grimar added inline comments.


================
Comment at: ELF/SymbolTable.cpp:419
       File->IsUsed = true;
+    File->SymVerMap[S] = Verdef;
   }
----------------
ruiu wrote:
> This seems tricky, but I have no clear idea how to do that in a different way. If you split this patch into two, you can check this in sooner. In this patch, you are doing two things -- one is to make .bss and .bss.rel.ro synthetic sections, and the other is to change the way how we represent copied shared symbols. Probably you want to focus on the former first. That should also reduce the risk of buildbot breakage.
Done: D30892


https://reviews.llvm.org/D30541





More information about the llvm-commits mailing list