[PATCH] D27309: builtins: Add ARM Thumb1 implementation for uidiv and uidivmod

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 11 05:58:52 PST 2017


rengolin added a comment.

In https://reviews.llvm.org/D27309#698618, @dim wrote:

> In FreeBSD, @strejda committed this rather big hammer to work around it:  https://reviews.freebsd.org/rS314907, basically disabling all thumb support. :(


Ouch, that's not good.

> I would certainly not object to reverting https://reviews.llvm.org/rL288710 for now, and put up a new review to handle all concerns. @strejda, you already had a bunch of suggestions in your github commit, right?

We can do that offline. I'm OOO, so if anyone could revert the patch(es) for now, that'd be great. If not, I'll do when I'm back home.

--renato


Repository:
  rL LLVM

https://reviews.llvm.org/D27309





More information about the llvm-commits mailing list