[PATCH] D30699: [ELF] - Stop producing broken output for R_386_GOT32X relocation.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 10 22:55:24 PST 2017


grimar added a comment.

In https://reviews.llvm.org/D30699#697854, @ruiu wrote:

> In short, do you mean that H.J. Lu's statement that GOT32X can be handled as GOT32 is wrong?


No, in short - I agree with that. 
And gnu linkers handle these relocations in the same way. That way is different from what we do now.

To match LLD behavior with GNU linkers we need to fix the calculation according to ABI, we do it wrong now and
broke the output.
Patch fixes handling for R_386_GOT32X case. If we change both R_386_GOT32 and R_386_GOT32X we will end
up with the same result as GNU linkers has.


https://reviews.llvm.org/D30699





More information about the llvm-commits mailing list