[PATCH] D30333: Split SimplifyCFG to run obscuring switch transforms only during last phase

[Joerg Sonnenberger via Phabricator via llvm-commits]

joerg added inline comments.


================
Comment at: lib/Transforms/Scalar/SimplifyCFGPass.cpp:256
+  }
+};
 }
----------------
mehdi_amini wrote:
> joerg wrote:
> > mehdi_amini wrote:
> > > Why two passes instead of a parameter?
> > Two passes makes it easier to test it on the command line.
> I can understand this aspect, but on the other hand that does not scale with adding more options, which is why we rarely do this. What other passes have the same approach?
I don't think we have a good example where parts of a pass are disabled. I could split them off into a separate pass, but that seems to be even worse. Normally we only have adjustable limits as configuration of passes.


https://reviews.llvm.org/D30333