[PATCH] D30785: [DWARF] Versioning for DWARF constants; verify FORMs

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

In https://reviews.llvm.org/D30785#698377, @clayborg wrote:

> I wonder since we are adding new macro parameters to some macros if we shouldn't add two params: version and vendor for anything that uses the special versions. Currently you are overloading version with vendor into a single integer, why not add both version and vendor?


As Blaikie said in email, extensions are unlikely to be versioned like standard values, and it seemed to me there was no useful value to put as the version for an extension. Also it adds yet another set of APIs to retrieve the values.  But as the admittedly minor code bloat is about the only downside, I'll go add that all in on Monday.


https://reviews.llvm.org/D30785