[PATCH] D21720: Unroll for uncountable loops

[Evgeny Stupachenko via Phabricator via llvm-commits]

evstupac added inline comments.


================
Comment at: lib/Transforms/Scalar/LoopUnrollPass.cpp:94
+    "unroll-allow-force", cl::Hidden, cl::init(false),
+    cl::desc("Allow generation of a loop remainder (extra iterations) "
+             "when unrolling a loop."));
----------------
zzheng wrote:
> Is this description copied from above flag?
> 
> allow-force sounds like forced unrolling... how about name it UnrollAllowUncountable (unroll-allow-uncountable)?
Right. Thanks for catching this. Will fix. "unroll-allow-uncountable" looks good.


================
Comment at: test/Transforms/LoopUnroll/unroll-force.ll:1
+; RUN: opt < %s -S -unroll-runtime -loop-unroll -unroll-allow-force | FileCheck %s
+; The test checks unroll for uncountable loop, when previous value is stored.
----------------
zzheng wrote:
> Maybe name this file 'unroll-uncountable.ll'?
Yes. Make sense. 


Repository:
  rL LLVM

https://reviews.llvm.org/D21720