[PATCH] D30818: [lsan] Don't handle DTLS of thread under destruction

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_tls_get_addr.cc:140
+bool DTLSInDestruction(DTLS *dtls) {
+  return dtls && dtls->dtv_size == kDestroyedThread;
+}
----------------
Please remove  dtls &&
!dtls is invalid and we should crash here



================
Comment at: lib/sanitizer_common/sanitizer_tls_get_addr.cc:148
 void DTLS_Destroy() {}
+bool DTLSInDestruction(DTLS *dtls) { return false; }
+
----------------
UNREACHABLE() ?


Repository:
  rL LLVM

https://reviews.llvm.org/D30818