[PATCH] D30835: [DebugInfo][X86] Teach Optimize LEAs pass to handle debug values

[Andrew Ng via Phabricator via llvm-commits]

andrewng added a comment.

In https://reviews.llvm.org/D30835#697933, @dblaikie wrote:

> Looks like this change does two things - fixes the "debug info affects optimization" and also does some work to improve optimized debug info quality? Might be worth separating this into two changes to make sure there's good test coverage/easier to review/etc?


I'm about to leave work now but I will look on Monday into whether separating this into two makes sense.



================
Comment at: lib/Target/X86/X86OptimizeLEAs.cpp:599
         // isReplaceable function.
+        const unsigned FirstVReg = First.getOperand(0).getReg();
         for (auto UI = MRI->use_begin(Last.getOperand(0).getReg()),
----------------
dblaikie wrote:
> LLVM doesn't have much top level const like this - I'd probably leave it off.
No problem, I will remove the const.


https://reviews.llvm.org/D30835