[PATCH] D30558: Fix value numbers in successor blocks if liveout number has changed

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 10 11:07:01 PST 2017


MatzeB added a comment.

Thanks for putting up the testcase!

I am still not convinced this is the best fix. Before invoking handleMove there must have been 1 value number living out of the block, we may create new value number in the process, however we should always be able to implement handleMove in a way that we re-use the value number that was live-out previous for whatever new value is live-out now. This means we have to fix `handleMoveUp()` and not add more core to work around a bug that really is in `handleMoveUp()`.


Repository:
  rL LLVM

https://reviews.llvm.org/D30558





More information about the llvm-commits mailing list