[PATCH] D30259: GlobalISel: Translate ConstantAggregateZero vectors

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/CodeGen/GlobalISel/IRTranslator.cpp:1018
+    if (!CAZ->getType()->isVectorTy()) {
+      if (!TPC->isGlobalISelAbortEnabled())
+        return false;
----------------
I would just return false.
The caller should check the fallback/abort status.

I know surrounding code does that, but we should fix that as well. I'll have a try.


================
Comment at: test/CodeGen/AArch64/GlobalISel/arm64-irtranslator.ll:1268
+; CHECK: %d0 = COPY [[VEC]](<2 x s32>)
+	ret <2 x float> zeroinitializer
+}
----------------
Add a non-power-of-2 test case


https://reviews.llvm.org/D30259