[PATCH] D30216: GlobalISel: Translate ConstantDataVector

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet accepted this revision.
qcolombet added a comment.

LGTM + test case



================
Comment at: test/CodeGen/AArch64/GlobalISel/arm64-irtranslator.ll:1193-1201
+define <2 x i32> @test_constant_datavector() {
+; CHECK-LABEL: name: test_constant_datavector
+; CHECK: [[ONE:%[0-9]+]](s32) = G_CONSTANT i32 1
+; CHECK: [[TWO:%[0-9]+]](s32) = G_CONSTANT i32 2
+; CHECK: [[RES:%[0-9]+]](<2 x s32>) = G_SEQUENCE [[ONE]](s32), 0, [[TWO]](s32), 32
+; CHECK: %d0 = COPY [[RES]](<2 x s32>)
+entry:
----------------
qcolombet wrote:
> kristof.beyls wrote:
> > dsanders wrote:
> > > I'd add a couple more tests, one for another vector size (preferably not a power of 2) and one for a different type and size like 'double'.
> > My guess is that non-power-of-2 vector sizes are too ill-supported to be able to write tests using them at the moment?
> > I'm currently starting to look into supporting non-power-of-2-sized types - it's looking like it may be quite a bit of work.
> For the IRTranslator non-power-of-2 vectors should be fine.
> At least I don't see any difficulty for this specific pass.
Could you add a non-power-of-2 test case?


https://reviews.llvm.org/D30216