[PATCH] D30738: Don't internalize llvm GV's with InternalizeLinkedSymbols

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

Code looks good, just a few nits about comments left.



================
Comment at: include/llvm/Linker/Linker.h:45
+                    std::function<void(Module &, const StringSet<> &)>
+                        InternalizeCallback = {});
 
----------------
Document new parameter


================
Comment at: lib/Linker/LinkModules.cpp:40
+  StringSet<> Internalize;
+  std::function<void(Module &, const StringSet<> &)> InternalizeCallback;
+
----------------
Document these members (doxygen-style "///")


================
Comment at: tools/llvm-link/llvm-link.cpp:276
   unsigned ApplicableFlags = Flags & Linker::Flags::OverrideFromSrc;
+  // Similar to some falgs, internalization doesn't apply to the first file.
+  bool InternalizeLinkedSymbols = false;
----------------
s/falgs/flags/


Repository:
  rL LLVM

https://reviews.llvm.org/D30738