[PATCH] D30738: Don't internalize llvm GV's with InternalizeLinkedSymbols

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere updated this revision to Diff 91297.
JDevlieghere marked 8 inline comments as done.
JDevlieghere added a comment.

- Feedback from Teresa and Mehdi

Regarding Peter's comment: While I like the idea of the `legalToInternalize`, I'm not convinced that it's really better than the callback. Most of the code in `InternalizePass` is concerned with deciding which GVs are legal to be internalized. Performing the actual internalization is only a small part, so why not keep a unified interface like it is today? Either way you'll need info from the linker about what symbols to internalize, and the callback nicely combines (1) indicating whether it is necessary and (2) performing it.

PS: I'm working on a test case.


Repository:
  rL LLVM

https://reviews.llvm.org/D30738

Files:
  include/llvm/Linker/Linker.h
  lib/Linker/LinkModules.cpp
  tools/llvm-link/llvm-link.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D30738.91297.patch
Type: text/x-patch
Size: 7217 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170310/943dd193/attachment.bin>