[PATCH] D30802: [Builtin] Implement lit-test support

[Jonathan Roelofs via Phabricator via llvm-commits]

jroelofs added inline comments.


================
Comment at: test/builtins/Unit/lit.cfg:67
+                              build_invocation(clang_builtins_cxxflags)))
+
+# FIXME: move the call_apsr.s into call_apsr.h as inline-asm.
----------------
Where does `%run` get expanded?


================
Comment at: test/builtins/Unit/lit.cfg:83
+# Only run the tests on supported OSs.
+if config.host_os not in ['Linux', 'Darwin', 'FreeBSD', 'Windows']:
+  config.unsupported = True
----------------
Please don't assume that $host == $target... This prevents remote cross testing.


https://reviews.llvm.org/D30802