[PATCH] D30738: Don't internalize llvm GV's with InternalizeLinkedSymbols

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added inline comments.


================
Comment at: tools/llvm-link/llvm-link.cpp:329
+
+    InternalizeLinkedSymbols |= Internalize;
+
----------------
JDevlieghere wrote:
> tejohnson wrote:
> > Previously the internalize flag was set before invoking this function from main(). With this being set after the first linkInModule it seems like a behavior change, or am I missing something?
> Indeed, however on line 275 it is cleared on the first iteration by AND'ing it with overrideFromSrc flag.
Ah, that's what I was missing. Please add a comment about why this isn't being applied to the first iteration.


Repository:
  rL LLVM

https://reviews.llvm.org/D30738