[PATCH] D30738: Don't internalize llvm GV's with InternalizeLinkedSymbols

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added inline comments.


================
Comment at: tools/llvm-link/llvm-link.cpp:326
+    } else {
+      Err = L.linkInModule(std::move(M), ApplicableFlags);
+    }
----------------
JDevlieghere wrote:
> tejohnson wrote:
> > Why is this needed since linkInModule has a default for the InternalizeCallback parameter?
> I'm sorry, I don't understand the question. The function is called with only two parameters so the default argument is used for the callback. No callback means no internalization, so thats what we want in the else branch? Am I overlooking something?
You are right, nevermind this comment! Looked at it too fast.


Repository:
  rL LLVM

https://reviews.llvm.org/D30738