[PATCH] D30738: Don't internalize llvm GV's with InternalizeLinkedSymbols

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 9 10:54:42 PST 2017


JDevlieghere updated this revision to Diff 91192.
JDevlieghere added a comment.

@tejohnson The symbols are local, so it doesn't cause an issue with regular linking. It only happens when we throw all the modules together.

@mehdi_amini: Is this what you had in mind?

I've run the tests and this implementation doesn't break any existing tests regarding linking with the internalize flag.


Repository:
  rL LLVM

https://reviews.llvm.org/D30738

Files:
  include/llvm/Linker/Linker.h
  lib/Linker/LinkModules.cpp
  tools/llvm-link/llvm-link.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D30738.91192.patch
Type: text/x-patch
Size: 9898 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170309/e69b9205/attachment.bin>


More information about the llvm-commits mailing list