[PATCH] D30417: [DAGCombiner] Do various combine on uaddo.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 9 10:23:03 PST 2017


RKSimon added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:1937
+  SDLoc DL(N);
+
+  // If the flag result is dead, turn this into an ADD.
----------------
deadalnix wrote:
> RKSimon wrote:
> > Similar to D30437 - please add an early out for vectors.
> As far as I know, there is no vector version fo this op.
Yes I don't think we can generate them at the moment, but I know other code (such as in computeKnownBits  and computeNumSignBits) already check for overflow vector types if/when we do get around to supporting them.


https://reviews.llvm.org/D30417





More information about the llvm-commits mailing list