[PATCH] D29177: [PowerPC][Altivec] Add mfvrd and mffprd extended mnemonic

Bruno Rosa via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 9 10:03:20 PST 2017


brunoalr added a comment.

In https://reviews.llvm.org/D29177#662704, @nemanjai wrote:

> Provide both of the extended mnemonics for MFVSRD and add/update tests for them.
>
> Please note that changes to test case `p8-scalar_vector_conversions.ll` may seem unrelated, but the unoptimized IR (no mem2reg) produces different mnemonics in some cases and not others (i.e. depending on which source register is selected). This update just locks the parameter registers to what the calling convention says and thereby fixes the mnemonic choice.


Hi there, @nemanjai!
Is there any other action that I should take for this patch to get approved?

Thanks.


Repository:
  rL LLVM

https://reviews.llvm.org/D29177





More information about the llvm-commits mailing list