[PATCH] archives require a symbol table on Solaris, even if empty

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 9 07:49:22 PST 2017


Danek Duvall <danek.duvall at oracle.com> writes:
> I've attached a new patch with an updated comment, a testcase, and an
> archive, with a git-style patch.  Let me know if there's a better way to do
> this.

Since the archive format is basically text, I think you can just use
FileCheck to test that we create a symbol table on an empty file. Take a
look at llvm/test/Object/archive-format.test. In fact, don't you have to
update that test with your patch?

Cheers,
Rafael



More information about the llvm-commits mailing list