[PATCH] D30539: [tablegen][globalisel] Add support for nested instruction matching.

[Kristof Beyls via Phabricator via llvm-commits]

kristof.beyls added a comment.

Thanks for the updates, Daniel!
I don't have further remarks, but I think it's best if someone who understands the details better (like @ab ?) would also have a look.



================
Comment at: test/TableGen/GlobalISelEmitter.td:131
+//===- Test another simple pattern with regclass operands. ----------------===//
+
 // CHECK-LABEL: if ([&]() {
----------------
Thanks very much for this test. I find the test also works well as documentation for what the expected generated code is for a simple piece of tablegen input.
I'm assuming that this is the single test file that drives code coverage statistics at http://llvm.org/reports/coverage/utils/TableGen/GlobalISelEmitter.cpp.gcov.html. I was already happily surprised to see so much line coverage there. It seems only error reporting isn't well covered by this test file.


https://reviews.llvm.org/D30539