[PATCH] D30749: [FileCheck] Added --enable-var-scope option to enable scope for regex variables.

[Artem Belevich via Phabricator via llvm-commits]

tra marked an inline comment as done.
tra added inline comments.


================
Comment at: docs/CommandGuide/FileCheck.rst:357
+If ``--enable-var-scope`` is in effect, all local variables are cleared at the
+beginning of the block.
+
----------------
jlebar wrote:
> Nit, "blocks" aren't really a concept in FileCheck.  Maybe we should just say "If ``--enable-var-scope`` is in effect, all local variables (i.e. variables that don't start with "$") are cleared when a CHECK-LABEL is encountered."
I've used `the block` because CHECK-LABEL documentation says (lines 353-355):
```
...the presence of ``CHECK-LABEL`` divides
the input stream into separate blocks, each of which is processed independently,
preventing a ``CHECK:`` directive in one block matching a line in another block.
```

I did start with a sentence along the lines of the one you've suggested, but decided to stick with blocks as it seems to be a better fit for something with 'scope'.


https://reviews.llvm.org/D30749