[PATCH] D30485: Perform symbol binding for .symver versioned symbols

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 8 12:37:28 PST 2017


> +  /// Get the state recorded for the given symbol.
> +  State symbolState(const MCSymbol *Sym) {

Maybe name it getSymbolState?

> +    // If we don't have a symbol attribute from assembly, then check if
> +    // the aliasee was defined in the IR.

It is a pity that we now need to look at both asm and IR, but I can't
think of simple solution for it.

This is fine with me, but please wait for pcc's review too.

Cheers,
Rafael


More information about the llvm-commits mailing list