[PATCH] D28966: [PGO] Memory intrinsic calls optimization based on profiled size

[Rong Xu via Phabricator via llvm-commits]

xur added a comment.

In https://reviews.llvm.org/D28966#694902, @davidxl wrote:

> The optimization pass should be split into two phases as IC promotion. The annotation part should probably  be merged with the instrumentation patch. The transformation patch should be done in the same pass as IndirectCallPromotion.


Is there a good reason for doing the transformation late?  Here I don't do the annotation and instead, I do the transformation directly in the same pass. The main reason we have annotations in indirect-call-promotion is we need to call it late (in LTO or ThinLTO). Another reason I'm reluctant to use annotation is that we need to maintain/update it (for inline and unroll, for example).

-Rong


https://reviews.llvm.org/D28966