[PATCH] D30747: TargetInstrInfo: Provide default implementation of isTailCall().

[Matthias Braun via Phabricator via llvm-commits]

MatzeB added a comment.

In https://reviews.llvm.org/D30747#695741, @kparzysz wrote:

> In https://reviews.llvm.org/D30747#695716, @MatzeB wrote:
>
> > I did not touch HexagonInstrInfo::isTailCall() here as it wasn't immediately obvious whether the flags are correct there and the default implementation would work. Some target maintainer should double check and if so maybe we can get rid of the complete callback.
>
>
> Hexagon has over 100 different opcodes for branches, and each of them can be used as a tail call.  We are not going to invent 100+ phony opcodes just to put flags on them.


Yes I somewhat expected this answer and that we will end up in a similar discussion as in http://llvm.org/PR31960. So let's keep the callback (and the comment about wrong flags).


Repository:
  rL LLVM

https://reviews.llvm.org/D30747