[PATCH] D30724: Dont emit Mapping symbols for Non allocatable sections.

[Shankar Easwaran via Phabricator via llvm-commits]

shankare added inline comments.


================
Comment at: lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp:479
+    MCSectionELF *CurSection = cast<MCSectionELF>(Section);
+    if (CurSection->UseCodeAlign())
+      LastEMS = EMS_None;
----------------
t.p.northover wrote:
> Now this is looking a lot more promising! But I don't see the need for any exceptions to an EMS_Data default. That seems to be exactly what the ABI says should happen.
EmitDataMappingSymbol relies on the value of LastEMS to emit a $d or not. If the stream had any instructions, LastEMS points to what the stream would be (EMS_ARM or EMS_Thumb). 


https://reviews.llvm.org/D30724